Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: align content vertically #83

Merged
merged 4 commits into from Jul 18, 2022

Conversation

Shabbyconnor
Copy link
Collaborator

@Shabbyconnor Shabbyconnor commented Jul 17, 2022

Okay, I've aligned the content vertically by making the navbar position absolute instead of relative. This does mean that I had to override Bootstrap with an id.

Closes #67

The content doesn't need to be horizontally aligned. In your previous image, you were comparing the center of the content with the center of the navbar buttons. The actual center of the navbar includes the little drop-down arrow.

Screen Shot 2022-07-17 at 12 18 05 PM

So while It may look off center, in the code it's doing what it should.

Screen Shot 2022-07-17 at 12 37 27 PM

I can try to shift the navbar over if you want it more aesthetically pleasing. 馃槂

@devkennyy devkennyy self-requested a review July 18, 2022 03:07
@devkennyy
Copy link
Owner

I am curious to see what it would look like with content on the left side.

@devkennyy devkennyy closed this Jul 18, 2022
@devkennyy devkennyy reopened this Jul 18, 2022
@devkennyy
Copy link
Owner

devkennyy commented Jul 18, 2022

Oops, ignore that 馃槄

@Shabbyconnor
Copy link
Collaborator Author

Shabbyconnor commented Jul 18, 2022

Okay, we've got two options: I can shift the whole navbar content over so it looks right, or I can delete the caret entirely.
This is what it looks like shifted:
Screen Shot 2022-07-18 at 12 21 47 AM

And this is it deleted:
Screen Shot 2022-07-18 at 12 17 55 AM
Which do you like better? (I personally don't think we need the caret)

@devkennyy
Copy link
Owner

devkennyy commented Jul 18, 2022

I also think we should remove the caret but what are your views on this?
image

@Shabbyconnor
Copy link
Collaborator Author

Hmm. The only way that would look good is if we had a pancake menu button to collapse the navbar horizontally.
Though I prefer keeping it in the center. I would suggest we at least change the navbar background color to match the rest of the page. It's just a bit too out of place.

@devkennyy
Copy link
Owner

Alright, that's fine. Feel free to change the colour to whatever you see fit.

@devkennyy devkennyy merged commit 5d66ba9 into devkennyy:master Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

center content horizontally
2 participants