Add example for stereoscopic 3D with citro2d #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fincs
reviewed
Feb 4, 2023
|
And also, |
Co-authored-by: fincs <fincs@devkitpro.org>
oreo639
reviewed
Feb 6, 2023
Comment on lines
+49
to
+53
| CFLAGS := -g -Wall -O2 -mword-relocations \ | ||
| -fomit-frame-pointer -ffunction-sections \ | ||
| $(ARCH) | ||
|
|
||
| CFLAGS += $(INCLUDE) -DARM11 -D_3DS |
There was a problem hiding this comment.
This is a bit late sorry, but -fomit-frame-pointer is useless here and -DARM11 -D_3DS should be replaced with -D__3DS__
In file included from /opt/devkitpro/libctru/include/c3d/types.h:3,
from /opt/devkitpro/libctru/include/citro3d.h:11,
from /opt/devkitpro/libctru/include/citro2d.h:15,
from /home/oreo639/git/3ds-examples/graphics/gpu/stereoscopic_2d/source/main.cpp:3:
/opt/devkitpro/libctru/include/3ds.h:12:2: warning: #warning "Please update your Makefile and replace -DARM11 -D_3DS with -D__3DS__" [-Wcpp]
12 | #warning "Please update your Makefile and replace -DARM11 -D_3DS with -D__3DS__"
| ^~~~~~~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only example I could find using both stereoscopic 3D and citro2d is the composite_scene example, which can look intimidating. This example aims to be as simple and as easy to understand as possible