Improve robustness of some newlib functions #54
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…verifying if returned value is a valid device id
|
Newlib patchset is maintained at https://github.com/devkitPro/newlib/tree/devkitPPC |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Crash can occur if those functions are called with a relative path before defaultDevice has been correctly initialized or with an unmounted device path.
It has been observed in Wii homebrew loaded with Wiiflow that crashes with a DSI exception when mkdir function is called because fatInitDefault() function failed to set defaultDevice (through chdir) using the application path provided in argv[0] by the loader (see ekeeke/Genesis-Plus-GX#357 and Fledge68/WiiFlow_Lite#254)
These changes improve the robustness of functions mkdir, link and rename against such edge case, similarly to what is already done for other syscall functions.