Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tj-actions/changed-files action to v37 [SECURITY] #18

Closed
wants to merge 2 commits into from
Closed

Update tj-actions/changed-files action to v37 [SECURITY] #18

wants to merge 2 commits into from

Conversation

renovate-bot
Copy link
Contributor

Mend Renovate

This PR contains the following updates:

Package Type Update Change
tj-actions/changed-files action major v36 -> v37

GitHub Vulnerability Alerts

CVE-2023-51664

Summary

The tj-actions/changed-files workflow allows for command injection in changed filenames, allowing an attacker to execute arbitrary code and potentially leak secrets.

Details

The changed-files action returns a list of files changed in a commit or pull request which provides an escape_json input enabled by default, only escapes " for JSON values.

This could potentially allow filenames that contain special characters such as ; and ` (backtick) which can be used by an attacker to take over the GitHub Runner if the output value is used in a raw fashion (thus being directly replaced before execution) inside a run block. By running custom commands an attacker may be able to steal secrets such as GITHUB_TOKEN if triggered on other events than pull_request. For example on push.

Proof of Concept

  1. Submit a pull request to a repository with a new file injecting a command. For example $(whoami).txt which is a valid filename.
  2. Upon approval of the workflow (triggered by the pull request), the action will get executed and the malicious pull request filename will flow into the List all changed files step below.
      - name: List all changed files
        run: |
          for file in $; do
            echo "$file was changed"
          done

Example output:

##[group]Run for file in $(whoami).txt; do
    for file in $(whoami).txt; do
        echo "$file was changed"
    done
shell: /usr/bin/bash -e {0}

##[endgroup]
runner.txt was changed

Impact

This issue may lead to arbitrary command execution in the GitHub Runner.

Resolution

  • A new safe_output input would be enabled by default and return filename paths escaping special characters like ;, ` (backtick), $, (), etc for bash environments.

  • A safe recommendation of using environment variables to store unsafe outputs.

- name: List all changed files
  env:
    ALL_CHANGED_FILES: $
  run: |
    for file in "$ALL_CHANGED_FILES"; do
      echo "$file was changed"
    done

Resources

Release Notes

tj-actions/changed-files (tj-actions/changed-files)

v37

Compare Source

Changes in v37.6.1
What's Changed

Full Changelog: tj-actions/changed-files@v37...v37.6.1

Changes in v37.6.0
What's Changed

Full Changelog: tj-actions/changed-files@v37...v37.6.0

Changes in v37.5.2
What's Changed

Full Changelog: tj-actions/changed-files@v37...v37.5.2

Changes in v37.5.1
What's Changed

Full Changelog: tj-actions/changed-files@v37...v37.5.1

Changes in v37.5.0
What's Changed

Full Changelog: tj-actions/changed-files@v37...v37.5.0

Changes in v37.4.0
What's Changed

Full Changelog: tj-actions/changed-files@v37...v37.4.0

Changes in v37.3.0
What's Changed

Full Changelog: tj-actions/changed-files@v37...v37.3.0

Changes in v37.2.0
What's Changed

Full Changelog: tj-actions/changed-files@v37...v37.2.0

Changes in v37.1.2
What's Changed

Full Changelog: tj-actions/changed-files@v37...v37.1.2

Changes in v37.1.1
What's Changed

Full Changelog: tj-actions/changed-files@v37...v37.1.1

Changes in v37.1.0
What's Changed

Full Changelog: tj-actions/changed-files@v37...v37.1.0

Changes in v37.0.5
What's Changed

Full Changelog: tj-actions/changed-files@v37...v37.0.5

Changes in v37.0.4
What's Changed

Full Changelog: tj-actions/changed-files@v37...v37.0.4

Changes in v37.0.3
What's Changed

Full Changelog: tj-actions/changed-files@v37...v37.0.3

Changes in v37.0.2
What's Changed

Full Changelog: tj-actions/changed-files@v37...v37.0.2

Changes in v37.0.1
What's Changed

Full Changelog: tj-actions/changed-files@v37...v37.0.1

Changes in v37.0.0
🚀 New Feature
  • This version introduces support for using Github's REST API to retrieve the list of changed files without requiring the checkout action.
Example
name: CI

on:
  pull_request:
    branches:
      - main

jobs:

##### -------------------------------------------------------------
##### Event `pull_request`: Returns all changed pull request files.

##### --------------------------------------------------------------
  job:  # Example - Using GitHub's API

##### NOTE: 
##### - This is limited to pull_request* events and would raise an error for other events.

##### - A maximum of 3000 files can be returned.
    runs-on: ubuntu-latest
    name: Test changed-files
    permissions:
      pull-requests: read
    steps:
      - name: Get changed files
        id: changed-files
        uses: tj-actions/changed-files@v37

      - name: List all changed files
        run: |
          for file in ${{ steps.changed-files.outputs.all_changed_files }}; do
            echo "$file was changed"
          done
🔥 Breaking Change
  • Removes the deprecated dir_names_exclude_root input which has been replaced by dir_names_exclude_current_dir
What's Changed

Full Changelog: tj-actions/changed-files@v36...v37.0.0

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@devlauer devlauer closed this Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@renovate-bot @devlauer