Improve time complexity for getGarbageLen

devleejb · Jan 3, 2024 · 610516f · 610516f
1 parent 79f0138
commit 610516f
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/src/document/crdt/root.ts b/src/document/crdt/root.ts
@@ -234,12 +234,19 @@ export class CRDTRoot {
   public getGarbageLen(): number {
     let count = 0;
     const seen = new Set<string>();
+    const sortedRemovedElementSetByCreatedAt = Array.from(
+      this.removedElementSetByCreatedAt,
+    ).sort();
 
-    for (const createdAt of this.removedElementSetByCreatedAt) {
+    for (const createdAt of sortedRemovedElementSetByCreatedAt) {
       seen.add(createdAt);
       const pair = this.elementPairMapByCreatedAt.get(createdAt)!;
       if (pair.element instanceof CRDTContainer) {
         pair.element.getDescendants((el) => {
+          const idString = el.getCreatedAt().toIDString();
+          if (seen.has(idString)) {
+            return true;
+          }
           seen.add(el.getCreatedAt().toIDString());
           return false;
         });