Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do we still need to use DynamicProxy's AttributesToAvoidReplicating? #1026

Closed
stakx opened this issue Jun 17, 2020 · 0 comments · Fixed by #1029
Closed

Do we still need to use DynamicProxy's AttributesToAvoidReplicating? #1026

stakx opened this issue Jun 17, 2020 · 0 comments · Fixed by #1029
Assignees
@stakx
Labels
dynamicproxy

Comments

@stakx
Copy link
Contributor

stakx commented Jun 17, 2020

The following code might be obsolete:

https://github.com/moq/moq4/blob/a20d1df93b678edc413ef8f0865a70c79d15dae9/src/Moq/ProxyFactories/CastleProxyFactory.cs#L35-L50

Looking at the current DynamicProxy source code...

  • the attributes guarded by FEATURE_COM are already excluded here

  • the security attributes guarded by FEATURE_CAS may already get excluded by a combination of this and this.

The last claim still needs to be verified. Once that's confirmed we should be able to remove the code section cited above.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stakx stakx

Labels
dynamicproxy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

No longer need to use AttributesToAvoidReplicating stakx/moq
1 participant
@stakx