Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verifying a protected generic method that returns a value is broken #1314

Closed
nthornton2010 opened this issue Dec 20, 2022 · 1 comment · Fixed by #1325
Closed

Verifying a protected generic method that returns a value is broken #1314

nthornton2010 opened this issue Dec 20, 2022 · 1 comment · Fixed by #1325
Assignees
@stakx
Labels
bug
Milestone
4.19.0

Comments

@nthornton2010
Copy link

This Verify method does not pass genericTypeArguments into InternalVerify, so this method will always throw an error because it thinks no generic type arguments were provided even though they were.

https://github.com/moq/moq4/blob/d535cc40870362f9667b64de1308fda3c204e6b8/src/Moq/Protected/ProtectedMock.cs#L253
@stakx
Copy link
Contributor

stakx commented Dec 29, 2022

Nice find @nthornton2010. Would you like to submit a PR to fix this?

@stakx stakx removed the up-for-grabs label Jan 2, 2023
@stakx stakx changed the title Verifying a generic method that returns a value is broken in ProtectedMock Verifying a protected generic method that returns a value is broken Jan 13, 2023
@stakx stakx mentioned this issue Jan 13, 2023
Merged
@stakx stakx self-assigned this Jan 13, 2023
@stakx stakx added this to the 4.19.0 milestone Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stakx stakx

Labels
bug
Projects
None yet
Milestone
4.19.0
2 participants
@stakx @nthornton2010