Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in condition #236

Closed
SviatoslavRazmyslov opened this issue Jan 2, 2016 · 2 comments
Closed

Typo in condition #236

SviatoslavRazmyslov opened this issue Jan 2, 2016 · 2 comments

Comments

@SviatoslavRazmyslov
Copy link

Due to an typo, there is no comparison with y.Method.

V3001 There are identical sub-expressions 'x.Method' to the left and to the right of the '==' operator. ExpressionComparer.cs 165

private bool EqualsBinary(BinaryExpression x, BinaryExpression y)
{
  return x.Method == x.Method && this.Equals(x.Left, y.Left) && this.Equals(x.Right, y.Right) && this.Equals(x.Conversion, y.Conversion);
}

This place is found by a static analyzer PVS-Studio.

@LeonidLevin
Copy link

I believe this has been solved in commit 13a5362
Please, mark as closed.

@kzu
Copy link
Contributor

kzu commented May 22, 2016

Thanks!

@kzu kzu closed this as completed May 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants