-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made minor changes to the files #31
Conversation
src/components/common/Footer.vue
Outdated
p Student Gymkhana IITJ | ||
p | ||
a(href="https://devlup-labs.github.io/#/" class="white--text" style="text-decoration: none;") Devlup Labs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove this link and add it to the v-footer
and change by Students' Gymkhana WebD Team
to Devlup Labs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested a minor change
Changes have been made as requested. |
@@ -20,7 +21,8 @@ | |||
v-footer(color="blue darken-2 white--text").text-center.justify-center.align-center | |||
h4.font-weight-regular © {{new Date().getFullYear() }} COPYRIGHT | Made with | |||
v-icon(color="red").pa-1 mdi-heart | |||
h4.font-weight-regular by Students' Gymkhana WebD Team | |||
a(href="https://devlup-labs.github.io/#/" class="white--text" style="text-decoration: none;") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add target="_blank"
in here and then I think I can merge
Done. |
okay LGTM |
Fixed issues #28 and #29.