Update to Muzei API 3.4, fixing issues on Android 10+ #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade all the way up to the new [Muzei API 3.4](https://github.com/romannurik/muzei/releases/tag/api3.4.0). This has a number of implications that affected quite a bit of code: - Muzei API 3.4 relies on Kotlin 1.3.72 and `compileSdkVersion` of 30. This required updating to Android Gradle Plugin 4.0.1 as well as AndroidX dependencies of WorkManager and Multidex. - Removes the remaining implementation of `BingImageOfTheDayArtSource` (every Muzei user has upgraded to Muzei 3.0+ by this point). - `COMMAND_ID_OPEN` has been removed entirely - that behavior is already handled by Muzei when you tap on the title on Muzei. It was Muzei API 3.2 that fixed _that_ on Android 10+ devices. - The new `getCommandActions()` API fixes the 'Share current Bing image' action on Android 10+ devices. By keeping the old APIs as well, we maintain backward compatibility with Muzei 3.3 users (although they'll still need to upgrade to Muzei 3.4 to get a working action). It now shows as a Share icon on Muzei 3.4. - Reworked the entire approach for sharing the image so that it works consistently without needing an extra copy of each image and the need for Picasso and FileProvider. This required reworking `BingImageContentProvider` to act as the stand in for `FileProvider` that directly talks to `BingImageOfTheDayArtProvider`. Fixes devmil#9
strievi
added a commit
to strievi/muzei-bingimageoftheday
that referenced
this pull request
Aug 4, 2020
Rework 02cbb9f to delegate responsibility of providing image files to `BingImageOfTheDayContentProvider`. This removes the need of an intermediary cache (`FileProvider`) as filenames are now set through `OpenableColumns.DISPLAY_NAME`. Also, missing cache files will be automatically recovered when external apps call `openFile()`. Note, however that some of them (e.g., Gmail/Drive/Keep on Android 5.1.1) will cause `NetworkOnMainThreadException`s since they are calling this synchronously. See also: devmil#10
|
Sorry for the late reply. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade all the way up to the new Muzei API 3.4. This has a number of implications that affected quite a bit of code:
compileSdkVersionof 30. This required updating to Android Gradle Plugin 4.0.1 as well as AndroidX dependencies of WorkManager and Multidex.BingImageOfTheDayArtSource(every Muzei user has upgraded to Muzei 3.0+ by this point).COMMAND_ID_OPENhas been removed entirely - that behavior is already handled by Muzei when you tap on the title on Muzei. It was Muzei API 3.2 that fixed that on Android 10+ devices.getCommandActions()API fixes the 'Share current Bing image' action on Android 10+ devices. By keeping the old APIs as well, we maintain backward compatibility with Muzei 3.3 users (although they'll still need to upgrade to Muzei 3.4 to get a working action). It now shows as a Share icon on Muzei 3.4.BingImageContentProviderto act as the stand in forFileProviderthat directly talks toBingImageOfTheDayArtProvider.Fixes #9