Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy information from Mamba.jl #19

Merged
merged 7 commits into from
Sep 1, 2021
Merged

Conversation

rikhuijzer
Copy link
Contributor

Hereby some more information from Mamba.jl to avoid the information going lost.

As a suggestion, I've also updated the LICENSE. I guess it is a good idea to mention the author of Mamba, since some of the code in MCMCDiagnosticTools.jl is the same verbatim, but maybe I've missed some memo about that Brian gave you guys distribution rights.

LICENSE Outdated Show resolved Hide resolved
LICENSE Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Jul 24, 2021

Pull Request Test Coverage Report for Build 1190397284

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.394%

Totals Coverage Status
Change from base Build 1015040812: 0.0%
Covered Lines: 522
Relevant Lines: 553

💛 - Coveralls

@codecov
Copy link

codecov bot commented Jul 24, 2021

Codecov Report

Merging #19 (2a240af) into main (13ae88c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #19   +/-   ##
=======================================
  Coverage   94.39%   94.39%           
=======================================
  Files           8        8           
  Lines         553      553           
=======================================
  Hits          522      522           
  Misses         31       31           
Impacted Files Coverage Δ
src/gelmandiag.jl 100.00% <ø> (ø)
src/gewekediag.jl 100.00% <ø> (ø)
src/heideldiag.jl 96.42% <ø> (ø)
src/rafterydiag.jl 97.14% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13ae88c...2a240af. Read the comment docs.

Copy link
Member

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be interesting how much and which part of the code is still copied from Mamba. I am not familiar with the origins of MCMCChains, I just found brian-j-smith/Mamba.jl#144.

You could use @doc + a raw string to avoid having to escape the LaTeX commands: https://docs.julialang.org/en/v1/manual/documentation/#and-\\-characters

src/gelmandiag.jl Show resolved Hide resolved
src/rafterydiag.jl Outdated Show resolved Hide resolved
src/rafterydiag.jl Outdated Show resolved Hide resolved
LICENSE Show resolved Hide resolved
@rikhuijzer
Copy link
Contributor Author

It would be interesting how much and which part of the code is still copied from Mamba.

Quite a bit, I would say. I do see that many changes have been made, but the core is clearly based on Mamba.jl.

Copy link
Member

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks a lot!

@devmotion devmotion merged commit 90f502d into TuringLang:main Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants