Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multi-line message support #32 #41

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nomsolence
Copy link
Contributor

This should fix the multi-line issue.

I'd also recommend using https://www.shellcheck.net/, and perhaps even just plain /bin/sh ([ -n "$2" ] instead of [[ "$2" ]], [ x = y ] instead of [ x == y ]). Plain shell only gets one array but that's fine.

Let me know if you'd like a conversion~

@devnetkc
Copy link
Owner

devnetkc commented Oct 3, 2020

The master branch should have passed shellchecker, did it not?

The script also started with /sh but evolved to use other things from /bash making the script need converted. Some things may have been missed, but obviously we're not used by me; so I skipped them to leave for beginner tickets.

I'll take a look if this fixes the issue today, thanks for your contribution 👍🏼

@devnetkc devnetkc added Hacktoberfest Good issues for Hacktoberfest bug Something isn't working labels Oct 3, 2020
@devnetkc devnetkc added this to On Deck in WordPress SSH Git CI via automation Oct 3, 2020
@devnetkc devnetkc self-requested a review October 3, 2020 11:18
Copy link
Owner

@devnetkc devnetkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still having trouble with it doing multi-line commits -- even when eliminating the pipeline automation out of the equation. There is also a strange extra merge happening with stage and dev branches asking for a commit message.
no idea where that is coming from, or if it's related to this PR. and i'm too busy today to do more testing

Screen Shot 2020-10-03 at 10 47 54 AM


  1. Do you have any screen shots of this posting multi-line commits?
    • If so, what was your call arguments?
# Bash command carried out on remote server
bash public_html/tests/wp-git-sync.sh -fo "https://user@dev.azure.com/org/proj/_git/tests" -pd "/public_html/tests" 

Screen Shot 2020-10-03 at 11 02 43 AM

Screen Shot 2020-10-03 at 10 59 07 AM


At this time, the issue mentioned has not been addressed enough to accept this change. Single line comments worked fine before, but this has added new issues I don't have time to debug for a release.

More information covering your debugging is required to accept.

Screen Shot 2020-10-03 at 11 09 29 AM

Screen Shot 2020-10-03 at 11 09 43 AM

@devnetkc
Copy link
Owner

devnetkc commented Oct 3, 2020

I ran a different test; the commit issue is highly likely to not be correlated and be user error on my part with my test environment. I was trying to skip the step of merging the pushed dev branch into the stage dir before running another test, or deleting the branches in both locations.

@nomsolence
Copy link
Contributor Author

Hmmm I'd have to delve more to understand what was happening. I figured the multi-line was simply bash eating the whitespace because there were no quotes.

@devnetkc
Copy link
Owner

devnetkc commented Oct 4, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Hacktoberfest Good issues for Hacktoberfest
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants