-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multi-line message support #32 #41
base: master
Are you sure you want to change the base?
Conversation
The master branch should have passed shellchecker, did it not? The script also started with /sh but evolved to use other things from /bash making the script need converted. Some things may have been missed, but obviously we're not used by me; so I skipped them to leave for beginner tickets. I'll take a look if this fixes the issue today, thanks for your contribution 👍🏼 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still having trouble with it doing multi-line commits -- even when eliminating the pipeline automation out of the equation. There is also a strange extra merge happening with stage and dev branches asking for a commit message.
no idea where that is coming from, or if it's related to this PR. and i'm too busy today to do more testing
- Do you have any screen shots of this posting multi-line commits?
- If so, what was your call arguments?
# Bash command carried out on remote server
bash public_html/tests/wp-git-sync.sh -fo "https://user@dev.azure.com/org/proj/_git/tests" -pd "/public_html/tests"
At this time, the issue mentioned has not been addressed enough to accept this change. Single line comments worked fine before, but this has added new issues I don't have time to debug for a release.
More information covering your debugging is required to accept.
I ran a different test; the commit issue is highly likely to not be correlated and be user error on my part with my test environment. I was trying to skip the step of merging the pushed dev branch into the stage dir before running another test, or deleting the branches in both locations. |
Hmmm I'd have to delve more to understand what was happening. I figured the multi-line was simply bash eating the whitespace because there were no quotes. |
That too is what I thought it was going to be until it was still not accepting the multi line entry from the command line.
Ryan Valizan
CEO
V-Network Solutions
206 N Harrison St
Spring Hill, KS 66083
(913)667-9268
GitHub/Twitter: @devnetkc
…________________________________
From: Somnolence <notifications@github.com>
Sent: Sunday, October 4, 2020 4:50:15 AM
To: devnetkc/wordpress-ssh-git-ci <wordpress-ssh-git-ci@noreply.github.com>
Cc: Ryan Valizan <ryan@vnetkc.com>; Comment <comment@noreply.github.com>
Subject: Re: [devnetkc/wordpress-ssh-git-ci] Fix multi-line message support #32 (#41)
Hmmm I'd have to delve more to understand what was happening. I figured the multi-line was simply bash eating the whitespace because there were no quotes.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#41 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AGIBWIGCENWKLOK2F44ACQLSJBANPANCNFSM4SCP6IZQ>.
|
This should fix the multi-line issue.
I'd also recommend using https://www.shellcheck.net/, and perhaps even just plain
/bin/sh
([ -n "$2" ]
instead of[[ "$2" ]]
,[ x = y ]
instead of[ x == y ]
). Plain shell only gets one array but that's fine.Let me know if you'd like a conversion~