Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upSupport adding your own DB's #52
Comments
This comment has been minimized.
This comment has been minimized.
devingDev
commented
Nov 3, 2018
|
maek ur own |
devnoname120
changed the title
use a non-shit homebrew database
Support Brewology as a DB
Nov 3, 2018
This comment has been minimized.
This comment has been minimized.
|
@KuromeSan Please show some respect for other developers' work, even if they have shortcomings. |
devnoname120
added
enhancement
help wanted
labels
Nov 3, 2018
This comment has been minimized.
This comment has been minimized.
devingDev
commented
Nov 3, 2018
|
btw u can mod it to use your own database |
This comment has been minimized.
This comment has been minimized.
|
honestly. it should just support adding a custom location for a database ^-^ |
KuromeSan
changed the title
Support Brewology as a DB
Support adding your own DB's
Nov 3, 2018
This comment has been minimized.
This comment has been minimized.
|
It already does in the code: Lines 7 to 14 in 1f54827 Feel free to do a pull request to put it in an external configuration file. |
This comment has been minimized.
This comment has been minimized.
DevDavisNunez
commented
Jan 26, 2019
•
|
Hello @devnoname120 !! However I have not made an extraction request since I only change the strings, and putting them in an external file would be a problem, maybe give the option to select both from the same application and only save which was the last selected for the next start. #define VHBB_DATA std::string("ux0:/data/VitaHbBrowser")
#define API_ENDPOINT std::string("http://devdavisnunez.x10.mx/wikihb/api/v1/?vhbb")
#define API_LOCAL std::string("ux0:/data/VitaHbBrowser/homebrews.yaml")
#define ICONS_FOLDER std::string("ux0:/data/VitaHbBrowser/icons")
#define ICON_URL_PREFIX std::string("http://devdavisnunez.x10.mx/wikihb/icons/")
#define SERVER_BASE_URL std::string("http://devdavisnunez.x10.mx/wikihb/")
#define SCREENSHOTS_FOLDER std::string("ux0:/data/VitaHbBrowser/screenshots")
|

KuromeSan commentedNov 3, 2018
•
edited by devnoname120
No description provided.