Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support adding your own DB's #52

Open
KuromeSan opened this issue Nov 3, 2018 · 6 comments

Comments

Projects
None yet
4 participants
@KuromeSan
Copy link

commented Nov 3, 2018

No description provided.

@devingDev

This comment has been minimized.

Copy link

commented Nov 3, 2018

maek ur own

@devnoname120 devnoname120 changed the title use a non-shit homebrew database Support Brewology as a DB Nov 3, 2018

@devnoname120

This comment has been minimized.

Copy link
Owner

commented Nov 3, 2018

@KuromeSan Please show some respect for other developers' work, even if they have shortcomings.

@devingDev

This comment has been minimized.

Copy link

commented Nov 3, 2018

btw u can mod it to use your own database

@KuromeSan

This comment has been minimized.

Copy link
Author

commented Nov 3, 2018

honestly. it should just support adding a custom location for a database ^-^

@KuromeSan KuromeSan changed the title Support Brewology as a DB Support adding your own DB's Nov 3, 2018

@devnoname120

This comment has been minimized.

Copy link
Owner

commented Nov 3, 2018

It already does in the code:

vhbb/src/macros.h

Lines 7 to 14 in 1f54827

#define API_ENDPOINT std::string("https://rinnegatamante.it/vitadb/list_hbs_yaml.php")
#define API_LOCAL std::string("ux0:/data/VitaHbBrowser/homebrews.yaml")
#define ICONS_FOLDER std::string("ux0:/data/VitaHbBrowser/icons")
#define ICON_URL_PREFIX std::string("https://rinnegatamante.it/vitadb/icons/")
#define SERVER_BASE_URL std::string("https://rinnegatamante.it/vitadb/")
#define SCREENSHOTS_FOLDER std::string("ux0:/data/VitaHbBrowser/screenshots")

Feel free to do a pull request to put it in an external configuration file.

@DevDavisNunez

This comment has been minimized.

Copy link

commented Jan 26, 2019

Hello @devnoname120 !!
I added support to the structure that VHBB requires in my WikiHomebrew project.
I've also tried compiling and using the vhbb from my server and it works.

2019-01-21-162548

However I have not made an extraction request since I only change the strings, and putting them in an external file would be a problem, maybe give the option to select both from the same application and only save which was the last selected for the next start.

#define VHBB_DATA std::string("ux0:/data/VitaHbBrowser")

#define API_ENDPOINT std::string("http://devdavisnunez.x10.mx/wikihb/api/v1/?vhbb")
#define API_LOCAL std::string("ux0:/data/VitaHbBrowser/homebrews.yaml")

#define ICONS_FOLDER std::string("ux0:/data/VitaHbBrowser/icons")
#define ICON_URL_PREFIX std::string("http://devdavisnunez.x10.mx/wikihb/icons/")

#define SERVER_BASE_URL std::string("http://devdavisnunez.x10.mx/wikihb/")
#define SCREENSHOTS_FOLDER std::string("ux0:/data/VitaHbBrowser/screenshots")
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.