Skip to content
This repository has been archived by the owner on Jul 19, 2022. It is now read-only.

Managing styles #200

Open
SachaG opened this issue Nov 15, 2019 · 0 comments
Open

Managing styles #200

SachaG opened this issue Nov 15, 2019 · 0 comments

Comments

@SachaG
Copy link
Member

SachaG commented Nov 15, 2019

Right now we have four potential places where colors and other styles can be defined:

  • The stylesheet
  • The Nivo theme (nivoTheme.js)
  • The constants file (constants.js)
  • The component file itself

Even without switching to a CSS-in-JS solution, I think we could get from 4 to 2 by deciding on the constants file (for example) as a single source of truth for all colors at least.

To help with that I created a new getColor(id) function (getColor('bars'), getColor('would_use_again'), etc.).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant