#36: Tool Commandlet for tomcat #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re/131-support-for-tool-dependecies
…thub.com/aBega2000/IDEasy into feature/131-support-for-tool-dependecies # Conflicts: # cli/src/main/java/com/devonfw/tools/ide/tool/ToolCommandlet.java
…thub.com/aBega2000/IDEasy into feature/131-support-for-tool-dependecies
…thub.com/aBega2000/IDEasy into feature/131-support-for-tool-dependecies
…131-support-for-tool-dependecies # Conflicts: # cli/src/main/java/com/devonfw/tools/ide/tool/LocalToolCommandlet.java
…thub.com/aBega2000/IDEasy into feature/131-support-for-tool-dependecies
…re/131-support-for-tool-dependecies
# Conflicts: # cli/src/main/java/com/devonfw/tools/ide/tool/LocalToolCommandlet.java
- Includes the tests for tool dependencies
…b.com/aBega2000/IDEasy into feature/36-tool-commandlet-for-tomcat
- Added recursive dependency installation - Added setup of environment variables for dependencies
# Conflicts: # cli/src/main/resources/nls/Ide.properties # cli/src/main/resources/nls/Ide_de.properties
# Conflicts: # cli/src/main/java/com/devonfw/tools/ide/tool/LocalToolCommandlet.java
hohwille
requested changes
Jun 13, 2024
There was a problem hiding this comment.
@aBega2000 thanks for taking this complex story further. You already made some good progress 👍
However, I still think that this story is too complex to get it solved via review comment feedback ping-pong.
IMHO we need to arrange a screen-sharing session and get this solved together to come to an end in a more efficient way.
hohwille
reviewed
Jun 17, 2024
# Conflicts: # cli/src/main/resources/nls/Help.properties # cli/src/main/resources/nls/Help_de.properties
9 tasks
hohwille
approved these changes
Jul 3, 2024
There was a problem hiding this comment.
@aBega2000 I reviewed and tested your latest code of this PR and tomcat is working. Great work👍
For the lots of review comments, that we discussed in a personal meeting, I created issue #439 for the review rework and therefore resolve the review comments and merge this as is.
hohwille
added a commit
to hohwille/IDEasy
that referenced
this pull request
Jul 3, 2024
incomplete, may not compile, just the state from the review meeting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #36, fixes #131
This is a pull request where Tomcat is implemented and tested.
Additionally the support for tool dependencies is implemented and tested.