Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#435 Fix version pattern for NpmUrlUpdater #436

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

slskiba
Copy link
Contributor

@slskiba slskiba commented Jul 1, 2024

Fixes #435.

While a rewrite of NpmUrlUpdater might be necessary to not use WebsiteUrlUpdater to parse versions from JSON, this provides a quick fix to additionally make versions 10.0.0, 10.1.0, 10.2.0, 10.2.1, 10.2.2, 10.2.3, 10.2.4, 10.2.5, 10.3.0, 10.4.0, 10.5.0, 10.5.1, 10.5.2, 10.6.0, 10.7.0, 10.8.0, and 10.8.1 of npm available.

@slskiba slskiba self-assigned this Jul 1, 2024
@coveralls
Copy link
Collaborator

coveralls commented Jul 1, 2024

Pull Request Test Coverage Report for Build 9744747259

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 60.328%

Totals Coverage Status
Change from base Build 9708861274: 0.0%
Covered Lines: 4989
Relevant Lines: 7960

💛 - Coveralls

Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slskiba thanks for the ultra fast fix. Awesome 👍

@hohwille hohwille added this to the release:2024.06.002 milestone Jul 1, 2024
@hohwille hohwille merged commit 53768a4 into devonfw:main Jul 1, 2024
4 checks passed
@jan-vcapgemini jan-vcapgemini added the reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. label Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented.
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

NpmUrlUpdater buggy - missing new npm versions in ide-urls
4 participants