Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slf4j version #204

Closed
maihacke opened this issue Feb 3, 2020 · 2 comments
Closed

slf4j version #204

maihacke opened this issue Feb 3, 2020 · 2 comments
Labels
enhancement New feature or request logging slf4j, logback, logstash, ELK, greylog, etc.

Comments

@maihacke
Copy link
Member

maihacke commented Feb 3, 2020

devon4j-bom currently contains a dependencymanagement for slf4j:

      <!-- Logging API -->
      <dependency>
        <groupId>org.slf4j</groupId>
        <artifactId>slf4j-api</artifactId>
        <version>1.7.7</version>
      </dependency>

in devon4j-logging we include jcl-over-slf4j. There is no dependency management for this dependency in devon4j-bom. Currently jcl-over-slf4j is resolved to version 1.7.28.

When looking at the new kafka module @ravicm2 is currently working on I ran into a problem with kafka in junit tests. The embedded kafka implementation expects slf4j 1.7.28, so I got a ClassNotFoundException for org.slf4j.event.Level.

The current slf4j version is 1.7.30.

We should think about which version of slf4j to include and assure this jcl-over-slf4j is also managed.

@maihacke maihacke added the enhancement New feature or request label Feb 3, 2020
@maihacke
Copy link
Member Author

maihacke commented Feb 3, 2020

@ravicm2 You will notice that I included part of that change in your kafka-branch e.g. my PR.

@maihacke maihacke added the logging slf4j, logback, logstash, ELK, greylog, etc. label Feb 3, 2020
@hohwille
Copy link
Member

Done with PR #205

@hohwille hohwille added this to the release:2020.04.00 milestone Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request logging slf4j, logback, logstash, ELK, greylog, etc.
Projects
None yet
Development

No branches or pull requests

2 participants