-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SQL errors in batch module #557
Comments
@rhobolic thanks for your issue. As we recommend(ed) to use h2 database for JUnit testing, we had written the SQL for h2. @maihacke do you have some cents on this?`Why did we actually have to use very h2 specific SQL here if we could have done it in a DB agnostic way? |
@hohwille honestly saying I started to remove H2 support in most of my projects I am in and run DB on demand with docker as all my projects are at least kubenetes deployments. My voting would be to get rid of H2 by default and propose DB in a container whenever possible. |
I'm not very sure, but propably it is because of the identity columns. Propably there is no hibernate orm magic here which decouples this from the database technology and spring batch just assumes that the column is handled by the DB.
I second this. But this has also a strong impact on CI/CD. But all in all the hassle with the containers (even in CI/CD) is better to solve than having to adopt the implementation (or tests) to different databases. |
Problem
If the batch module is generated out of the archetype and the batch is executed then sql errors arrise on the batch tables.
Expectation
No sql errors are present and everything is working out of the box
Solution hint
![image](https://user-images.githubusercontent.com/99953472/171581315-ccc172ba-51c6-4306-bbd4-091a8a1c1749.png)
We have chosen postgre in the archetype instead of h2. It could be that the "Add_batch_tables.sql" is working just in h2 and is h2 specific. In below screenshot you can see what needs to be done that it works for postgre.
The text was updated successfully, but these errors were encountered: