-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jwtbr needs to merged in develop #238
Conversation
I will have a closer look and do some final improvements myself. I am not yet sure when I will find a day of time to get this done. |
We would really need an example demostrating this feature in action. I added some fundamental tests but do not have the time to complete the tests right now (already way to late).
|
@vapadwal how do we proceed? Should I merge this and you create another PR for improvements or will you create a PR for this PR before we merge? |
both plans sounds good, but it would be better if you merge this PR first |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still need some improvements for tests and documentation but we will do this step by step as this story has grown too big. So I will approve and merge...
Implementation for #241