Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress sample #165

Merged
merged 15 commits into from Aug 3, 2020
Merged

Cypress sample #165

merged 15 commits into from Aug 3, 2020

Conversation

monicalopezgris
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jul 22, 2020

CLA assistant check
All committers have signed the CLA.

@sjimenez77
Copy link
Member

Please @monicalopezgris, review the Asciidoc you wrote. There are some issues. For example:

In order to write code you should use the following text:

[source, TypeScript]
----
Your code here
----
(and then a line break)

When you write a list do not start in the next line as sometimes the parser is not able to understand it. Put always a line break.

I will continue reviewing...

@sjimenez77
Copy link
Member

sjimenez77 commented Jul 27, 2020

Please @monicalopezgris, inside paragraphs do not add line breaks as you do not know where this break is going to appear in the rendered page. If you need to see the whole paragraph you can toggle word wrap in your editor (in VS Code the shortcut is ALT + Z).

Copy link
Member

@sjimenez77 sjimenez77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add links to the official documentation in the different sections of this documentation.

Try to elaborate more a little bit what you are showing in this documentation. We should consider our users as newbies with Cypress and explain the reasons. For example, you explain how to add a tsconfig.json but you do not say why!

I do not want to add a full replacement of the official documentation but try to see the rest of the documentation and you will understand what we are looking for.

documentation/guide-cypress.asciidoc Show resolved Hide resolved
monica.lopez-gris added 2 commits July 30, 2020 23:23
@sjimenez77 sjimenez77 merged commit 6b3ce39 into devonfw:develop Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants