#93: changed rules priorities and removed one (#103)

Added missing negation of method severity.isEmpty()
devonfw · Nov 12, 2020 · 1ee05b6 · 1ee05b6
1 parent 2a58998
commit 1ee05b6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 10 deletions.
diff --git a/src/main/java/com/devonfw/ide/sonarqube/common/impl/DevonfwJavaProfile.java b/src/main/java/com/devonfw/ide/sonarqube/common/impl/DevonfwJavaProfile.java
@@ -99,7 +99,7 @@ public void define(Context context) {
 
       if (!(FORBIDDEN_REPO_KEYS.contains(repoKey) || repoKey == null || ruleKey == null)) {
         currentRule = devonfwJava.activateRule(repoKey, ruleKey);
-        if (severity.isEmpty()) {
+        if (!severity.isEmpty()) {
           currentRule.overrideSeverity(severity);
         }
       }

diff --git a/src/main/resources/com/devonfw/ide/sonarqube/common/rules/devon4j/devon4j.xml b/src/main/resources/com/devonfw/ide/sonarqube/common/rules/devon4j/devon4j.xml
@@ -8777,13 +8777,6 @@
         <priority>CRITICAL</priority>
         <parameters/>
     </rule>
-    <rule>
-        <repositoryKey>java</repositoryKey>
-        <key>S2063</key>
-        <type>CODE_SMELL</type>
-        <priority>CRITICAL</priority>
-        <parameters/>
-    </rule>
     <rule>
         <repositoryKey>java</repositoryKey>
         <key>S2065</key>
@@ -9668,7 +9661,7 @@
         <repositoryKey>java</repositoryKey>
         <key>S2699</key>
         <type>CODE_SMELL</type>
-        <priority>BLOCKER</priority>
+        <priority>INFO</priority>
         <parameters/>
     </rule>
     <rule>
@@ -11367,4 +11360,4 @@
         <parameters/>
     </rule>
   </rules>
-</profile>
+</profile>