Rework issues from sonarsource.io

[hohwille]

With #40 we are now analyzing our own plugin code. The issues found by SonarQube should be analysed and reworked where possible/makes sense (e.g. remove outcommented code, get rid of System.out).
https://sonarcloud.io/project/issues?id=devonfw_sonar-devon4j-plugin&resolved=false&types=CODE_SMELL

[lmarniazman]

What about the 'bugs' shown in the analysis?

[lmarniazman]

About half of the code smells have been fixed with PR #50, so the quality gate is green now. However, there are still seven code smells and three bugs open, so I will look into fixing them in a seperate PR.

[hohwille]

3 bugs left:

• tree may be null - valid point. Just add null check and return immediately in that case.
• tree may be null 2 - same problem
• getter and property mismatch - actually intended. However if that is the last remaining issue, why not renaming the fields accordingly (errors -> errorsMutable and errorsView -> errors) to make SonarQube happy.

[lmarniazman]

As far as I can see, there already is a null check for the two NPE. I added an if(this.tree == null) {return;} after a call of getTreeInstance(context);

[hohwille]

IMHO all done and issue can be closed. Correct or am I missing something?

[lmarniazman]

Yes, issues were fixed with PR #64.

[hohwille]

All fixed now, hence closing.