Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add instrumenter option parse #8

Closed
wants to merge 1 commit into from

Conversation

ouhouhsami
Copy link

Based on issue #7 I add the possibility to give a specific istanbul instrument for browserify-istanbul.

@bassettsj
Copy link

+1 here.

@devongovett
Copy link
Owner

Just merged #11 which allows passing an instrumenterConfig option to configure Istanbul. Does that work for you?

@lukescott
Copy link

This is also needed for isparta, which is similar but uses 6to5. The instrumenter needs to be replaced as it "sub-classes" istanbul to transform es6 code and fix the line numbers.

The PR works, but has to be used like this:

{transform: [istanbul({
    ignore: ["node_modules/**/*.js", "test/**/.js"],
    instrumenter: new (require("isparta")).Instrumenter()
})]}

I made a comment above, which should allow it to be this instead:

{transform: [istanbul({
    ignore: ["node_modules/**/*.js", "test/**/.js"],
    instrumenter: require("isparta")
})]}

@devongovett
Copy link
Owner

Closing since #14 was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants