Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixes issue where a license expression wasn't being utilized #108

Merged
merged 2 commits into from
Jan 6, 2023

Conversation

djschleen
Copy link
Member

@djschleen djschleen commented Jan 4, 2023

  • fix: STDOUT provider will now print scanned file information and license information if there are no vulnerabilities detected.
  • fix: CycloneDX license extraction now looks for expression first and uses it, and if it is set to "" it will use the license node if it isn't nil.

I'm going to open a ticket to create some schema validation to ensure that any file ingested by bomber has all the fields bomber needs to process the file.

@djschleen
Copy link
Member Author

closes #106

@djschleen djschleen linked an issue Jan 4, 2023 that may be closed by this pull request
@djschleen djschleen added this to the 0.4.1 milestone Jan 4, 2023
@djschleen djschleen added bug Something isn't working enhancement New feature or request labels Jan 4, 2023
@djschleen djschleen self-assigned this Jan 4, 2023
@codecov
Copy link

codecov bot commented Jan 4, 2023

Codecov Report

Base: 86.94% // Head: 87.55% // Increases project coverage by +0.60% 🎉

Coverage data is based on head (4dcfe83) compared to base (9ee85bb).
Patch coverage: 90.69% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #108      +/-   ##
==========================================
+ Coverage   86.94%   87.55%   +0.60%     
==========================================
  Files          17       17              
  Lines         743      747       +4     
==========================================
+ Hits          646      654       +8     
+ Misses         65       63       -2     
+ Partials       32       30       -2     
Impacted Files Coverage Δ
renderers/stdout/stdout.go 82.14% <88.23%> (+2.14%) ⬆️
formats/cyclonedx/cyclonedx.go 100.00% <100.00%> (ø)
lib/bomloader.go 85.71% <100.00%> (+3.10%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@djschleen djschleen requested a review from serukii January 5, 2023 20:10
Copy link

@zroll zroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeCov agrees with you too.

@djschleen djschleen requested a review from zroll January 6, 2023 17:57
@djschleen djschleen merged commit 1a421ad into main Jan 6, 2023
@djschleen
Copy link
Member Author

Force approved... need to get CODEOWNERS in this repo for The Incredibles.

@djschleen djschleen deleted the dj-wip branch January 6, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

bomber fails when licenses are specified as expression
2 participants