Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fixes #138

Merged
merged 3 commits into from
Mar 3, 2023
Merged

Bug Fixes #138

merged 3 commits into from
Mar 3, 2023

Conversation

djschleen
Copy link
Member

@djschleen djschleen commented Mar 1, 2023

  • Doesn't process components without purls (or empty purl nodes)
  • Release artifact SBOM was incorrectly generating an SPDX file instead of CycloneDX

closes #137
closes #132

@djschleen djschleen changed the title Doesn't process components without purls (or empty purl nodes) Bug Fixes Mar 1, 2023
@djschleen djschleen requested a review from zroll March 1, 2023 23:48
@djschleen djschleen self-assigned this Mar 1, 2023
@djschleen djschleen added this to the 0.4.2 milestone Mar 1, 2023
@djschleen djschleen added bug Something isn't working enhancement New feature or request labels Mar 1, 2023
@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03 🎉

Comparison is base (5c7e7dd) 88.25% compared to head (8a849c4) 88.28%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #138      +/-   ##
==========================================
+ Coverage   88.25%   88.28%   +0.03%     
==========================================
  Files          18       18              
  Lines         766      768       +2     
==========================================
+ Hits          676      678       +2     
  Misses         60       60              
  Partials       30       30              
Impacted Files Coverage Δ
formats/cyclonedx/cyclonedx.go 100.00% <100.00%> (ø)
formats/spdx/spdx.go 100.00% <100.00%> (ø)
formats/syft/syft.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@djschleen djschleen merged commit 579b39b into main Mar 3, 2023
@djschleen djschleen deleted the bugfix branch March 3, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
2 participants