Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Error handling #158

Merged
merged 9 commits into from
Apr 14, 2023
Merged

feat: Error handling #158

merged 9 commits into from
Apr 14, 2023

Conversation

djschleen
Copy link
Member

Adds an Issue struct that can be used to encapsulate issues with SBOMs before services are called to process the SBOMs. Issues are output to STDOUT as warnings.

closes #152
closes #139

@djschleen djschleen requested a review from mirxcle April 14, 2023 19:12
@djschleen djschleen self-assigned this Apr 14, 2023
@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -1.03 ⚠️

Comparison is base (e847795) 88.28% compared to head (84c1802) 87.25%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #158      +/-   ##
==========================================
- Coverage   88.28%   87.25%   -1.03%     
==========================================
  Files          18       19       +1     
  Lines         768      769       +1     
==========================================
- Hits          678      671       -7     
- Misses         60       68       +8     
  Partials       30       30              
Impacted Files Coverage Δ
lib/enrichment/epss.go 86.36% <0.00%> (-0.60%) ⬇️
lib/filters/purl.go 0.00% <0.00%> (ø)
providers/ossindex/OSSIndex.go 84.78% <0.00%> (-0.64%) ⬇️
providers/snyk/snyk.go 77.14% <ø> (ø)
renderers/stdout/stdout.go 82.14% <0.00%> (ø)
lib/loader.go 88.31% <77.77%> (+0.65%) ⬆️
lib/util.go 100.00% <100.00%> (ø)
renderers/json/json.go 57.14% <100.00%> (+7.14%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@mirxcle mirxcle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice

@djschleen djschleen merged commit ce7c346 into main Apr 14, 2023
3 of 5 checks passed
@djschleen djschleen deleted the error-handling branch April 14, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

error retrieving vulnerability data (400 Bad Request) Same test SBOM 500's OSSINDEX but not OSV
2 participants