Skip to content

Commit

Permalink
linkerd fix
Browse files Browse the repository at this point in the history 
binenv only accepts semver formatted versions. hence, edge-X.Y.Z is not possible

to solve this, we excluded "edge" versions, keeping only "stable" ones.

relates to #231
  • Loading branch information
@leucos
leucos committed Feb 28, 2023
1 parent 8c1f1e4 commit 99386aa
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions distributions/cache.json
View file
Expand Up @@ -1493,6 +1493,7 @@
"1.11.1",
"1.11.0",
"1.10.2",
"1.10.1",
"1.10.0",
"1.9.1",
"1.9.0",
Expand Down
4 changes: 2 additions & 2 deletions distributions/distributions.yaml
View file
Expand Up @@ -2391,10 +2391,10 @@ sources:
url: https://github.com/linkerd/linkerd2/
list:
type: github-releases
exclude: "edge"
url: https://api.github.com/repos/linkerd/linkerd2/releases
fetch:
filters: filters
url: https://github.com/linkerd/linkerd2/releases/download/{{ .Version }}/linkerd2-cli-{{ .Version }}-{{ .OS }}-{{ .Arch }}
url: https://github.com/linkerd/linkerd2/releases/download/stable-{{ .Version }}/linkerd2-cli-stable-{{ .Version }}-{{ .OS }}-{{ .Arch }}
install:
type: direct
binaries:
Expand Down

4 comments on commit 99386aa

@Sierra1011
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies if this is just my not understanding this, but the release versions are actually named "stable-x.x.x" or "edge-x.x.x", so unless binenv is parsing the release names and extracting the portion that does comply with SemVer format this will be returning stable-stable-x.x.x.

@Sierra1011
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I've just seen c926ac8 😞
Does this mean it's a solid no for Linkerd in binenv?

@leucos
Copy link
Contributor Author

@leucos leucos commented on 99386aa Mar 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am sorry to say that, unfortunately, it is not possible atm

We might have to implement some kind of version pre-parsing I guess to make it work, but that would be clumsy and might have big side effects

I am too busy right now to tackle this and there are many other issues that deserves my attention too

If you feel like taking a shot at it, we can talk about it.

@Sierra1011
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a problem, thanks for the time you've spent on it and apologies for [unintentionally] breaking things!
I'll see if I can get some time to put into it.

Please sign in to comment.