Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PDX-2017] The Influx folks asked us to update their logo. Right on #2160

Conversation

BillWeiss
Copy link
Contributor

Looks the same to me, but, they asked...

@MikeRosTX
Copy link
Contributor

@BillWeiss when I update DC it update all the sites Influxdb chose to sponsor. So I'm closing and not merging this request.

@mattstratton
Copy link
Member

I wish it was a little bigger...but I'm not going to worry about it too much. At least 200px wide is recommended. If you have a higher-res version they sent you, get it to me somehow and I'll make some sponsor file magic, but I'm okay with this merge now.

@MikeRosTX MikeRosTX closed this Mar 28, 2017
@mattstratton
Copy link
Member

IMHO, this is a small enough difference in the logo file that it's not rewriting history, so I wouldn't mind, but if we are gonna do it, I want a higher resolution file :)

@mattstratton
Copy link
Member

What I really don't want to do is add another image file (influxdb-pdx.png) for what appears to not be a change at all; the blast radius to other events seems very small, vs the impact to the repo of having yet another file to process.

@mattstratton
Copy link
Member

given the minimal blast radius, I'm going to re-open this PR, but @BillWeiss I would like you to update it with a higher res version of the logo (if they provided you with one) and then we can merge it.

@bridgetkromhout
Copy link
Collaborator

Ah, I see what's going on here. So, this was actually already updated in #2151. The sponsor didn't understand that they don't have to contact every event. That's why we can't see the change - because it already happened.

Also, as I explained in #2150 (comment) we don't change the past. None of these events are past, so the change is fine as it stands. We don't need to rename/keep the old logo. See the discussion in #503 for how we preserve history when updating a logo that was used on an event that's already started/is past.

@mattstratton
Copy link
Member

So basically, we can close this PR after all, unless @BillWeiss has a higher res versionto supply :)

@BillWeiss BillWeiss deleted the pdx-2017-influxdata-logo-update branch March 30, 2017 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants