Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMS-2019] Fix the Valtech logo #6934

Closed
wants to merge 1 commit into from

Conversation

PaulusTM
Copy link
Contributor

Valtech contacted us about the logo not being the official version. As they are also a sponsor of the Kiev event, this will also change it on the Kiev page. This is expected.

Signed-off-by: Daniel Paulus <d.paulus@gmail.com>
@kmugrage
Copy link
Contributor

@dpnl87 it appears this would also change an event in the past, AMS 2017. This means that the event in the past has to be updated so that it doesn't change. That's done by creating a new sponsor called valtech-before-20190415, changing the old logo to match that name, modifying AMS 2017 to use the older version, and then using the new version on future events (2019 AMS, Kyiv, Stockholm).

You can see #503 for more context and info, and of course let us know if you have questions / need help.

@PaulusTM
Copy link
Contributor Author

@kmugrage It appears the logo has always been wrong. With them now being a sponsor for more events they started to notice. So with it updating the 2017 event as well ( AMS was their first sponsored event ) would be a good thing.

@kmugrage
Copy link
Contributor

I understand @dpnl87 - but we're not allowed to rewrite history. If you check out the original thread it was actually me as a sponsor wanting to change our old one but got overruled.

@bridgetkromhout
Copy link
Collaborator

Screen Shot 2019-04-15 at 3 05 39 PM

@kmugrage is correct - we don't change history - we keep the time-period-appropriate past logos.

A google search shows that that past logo was in fact used historically. (In some places, like glassdoor, it's still being used to this day.)

The good news is that it's similar enough to the new logo that it shouldn't lead to much confusion having it on an old page. We'll happily change it for all future events.

@bridgetkromhout
Copy link
Collaborator

When the build finishes we should be able to resolve this. Thanks.

@bridgetkromhout
Copy link
Collaborator

The update is complete (with a scaled-down image). Thanks!

@PaulusTM
Copy link
Contributor Author

Thank you @bridgetkromhout and @kmugrage!

@PaulusTM PaulusTM deleted the sponsor/valtech branch July 7, 2020 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants