Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deleting extra lines in Dockerfiles #57

Merged
merged 1 commit into from
Aug 9, 2023
Merged

deleting extra lines in Dockerfiles #57

merged 1 commit into from
Aug 9, 2023

Conversation

ArmanTaheriGhaleTaki
Copy link
Contributor

@ArmanTaheriGhaleTaki ArmanTaheriGhaleTaki commented Jun 19, 2023 •
edited
Loading

issue number #56

Changes:

the changes are

  • 07-Python/python-django/Django
  • 10-Angular/angular/Dockerfile
  • 10-Angular/README.md

RUN mkdir [directory] is deleted because it's extra
stack overflow page for this tip

Checklist

  • I have tested the changes locally.
  • I have merged the latest changes from the main branch.
  • I have added necessary documentation (if appropriate).
  • I have updated the README (if appropriate).

@ArmanTaheriGhaleTaki ArmanTaheriGhaleTaki changed the title fix(delete RUN mkdir): you dont need to use RUN mkdir while using WOR… deleting extra lines in Dockerfiles Jun 19, 2023
@ArmanTaheriGhaleTaki ArmanTaheriGhaleTaki mentioned this pull request Jun 19, 2023
Closed
mehdi-ra
mehdi-ra approved these changes Aug 9, 2023
View reviewed changes
Copy link
Collaborator

@mehdi-ra mehdi-ra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ❤️

@mehdi-ra mehdi-ra merged commit e0a67ec into devopshobbies:main Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehdi-ra mehdi-ra mehdi-ra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ArmanTaheriGhaleTaki @mehdi-ra