Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not serialize undefined attributes #192

Merged

Conversation

tomers
Copy link
Collaborator

@tomers tomers commented Jul 15, 2019

Priority

Low

What Changed & Why

  • Prevent undefined attributes from being serialized in the request
  • Prevent the attributes object attribute from being serialized if empty

Testing

Added two unit-tests. See code.

Bug/Ticket Tracker

#141

@tomers tomers requested a review from Auspicus July 15, 2019 20:40
@tomers tomers self-assigned this Jul 15, 2019
@Auspicus
Copy link
Collaborator

This is great. Will release this in a patch release once I get a chance to play around with it.

@Auspicus Auspicus merged commit b8b8e90 into devour-js:master Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants