Upgrade jsonpointer, standard, and mocha #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auvipy
approved these changes
Nov 17, 2021
|
the code changes seems appropriate to me. btw don't we have any CI active? if not I want to start one |
@auvipy we do! You can find two badges at the top of the readme file that link to this page on Travis and [this one for Snyk[(https://snyk.io/test/github/twg/devour). Travis got sold a few years ago to some company that is not doing much with it though. So I'm all for replacing it with another CI solution if you know a better one. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed & Why
My goal was to resolve this dependabot alert and while doing so I upgraded the standard package to the latest version. Then I ran
npm run autofixto format the code according to the latest standards (this makes the PR huge; my apologies) and fixed the mocha configuration since it got updated too and its default configuration settings changed over time.TLDR: I dragged a few libraries into the modern age and this introduced many small code changes.