Add Font Awesome integration #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r17x
reviewed
Apr 20, 2019
r17x
reviewed
Apr 20, 2019
Codecov Report
@@ Coverage Diff @@
## master #16 +/- ##
===========================================
- Coverage 100% 57.89% -42.11%
===========================================
Files 4 4
Lines 19 19
Branches 3 3
===========================================
- Hits 19 11 -8
- Misses 0 8 +8
Continue to review full report at Codecov.
|
zainfathoni
requested changes
Apr 20, 2019
There was a problem hiding this comment.
Please sign all your commits, otherwise, this PR will never be merged.
I've set the branch configuration to always require commit signing.
You can do it by cherrypick-ing your commits and signing the new commits.
nagacoder
force-pushed
the
feature/fontAwesome
branch
2 times, most recently
from
77e2304
to
baf506d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Add Font Awesome integration
Why:
How:
Checklist: