Set Test Coverage Threshold to 100% #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #17 +/- ##
========================================
+ Coverage 57.89% 100% +42.1%
========================================
Files 4 4
Lines 19 19
Branches 3 3
========================================
+ Hits 11 19 +8
+ Misses 8 0 -8
Continue to review full report at Codecov.
|
r17x
approved these changes
Apr 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: This set test coverage threshold to 100%
Why: To avoid regression as much as possible
How: By setting
coverageThresholdconfiguration injest.config.jsand (of course!) writing the test to reach 100% coverage, otherwise the CI build in this PR will fail for sure. 馃槄Checklist: