Early integration of e2e test using Cypress #18

andriawan · 2019-04-20T15:44:31Z

What: Integrating e2e test with Cypress

Why: to automate test browser event interaction such click event

How:

Checklist:

Tests
Ready to be merged

Dear all reviewers. I try to integrate Cypress e2e test. I am surely aware that there is a lot of improvement which should be added. therefore, inform me what should I do for improvement if any (sure a lot).

Thanks for letting me join this project @zainfathoni @ri7nz

zainfathoni

TODO:

Please replace all example tests with your own tests to actually test our website
Please integrate the cypress test into our current Continuous Integration (CI) flow.
If you're not sure about how to do this, I can help you with it.

package.json

andriawan · 2019-04-20T16:08:17Z

Thanks @zainfathoni... i'll improve it. About integrating with CI, i am not sure i can handle whole of the process...give me a hand :)

andriawan · 2019-04-20T16:22:38Z

TODO:

Please replace all example tests with your own tests to actually test our website

Please integrate the cypress test into our current Continuous Integration (CI) flow.
If you're not sure about how to do this, I can help you with it.

i am not sure in making my own e2e test @zainfathoni. Please give me few sample to follow

zainfathoni · 2019-04-20T16:27:43Z

@andriawan I just invited you as a collaborator in my private personal project.
You can follow the cypress integration I implemented over there.
Please don't hesitate to raise a question if you don't know where to look.
Thanks!

andriawan · 2019-04-20T16:32:06Z

@andriawan I just invited you as a collaborator in my private personal project.
You can follow the cypress integration I implemented over there.
Please don't hesitate to raise a question if you don't know where to look.
Thanks!

I am honored to be invited @zainfathoni. I'll check it

zainfathoni · 2019-04-20T16:37:10Z

Please implement it in this project comprehensively, so that in the future I can always point to this public implementation as an example for anybody asking the same thing. 😁

andriawan · 2019-04-20T16:43:48Z

Please implement it in this project comprehensively, so that in the future I can always point to this public implementation as an example for anybody asking the same thing. 😁

i will try my best @zainfathoni... need several technical adaptation i think 😄

zainfathoni · 2019-04-20T18:59:44Z

cypress/e2e/test.js

+  });
+
+  it("navigating to page-2", () => {
+    cy.visit("page-2");


This action means that the user accesses page-2 by typing in the address bar.
That's not what we want to test.

What we want is, when the user clicks the Go to page 2 button, the website should navigate to the correct URL and page.

zainfathoni · 2019-04-20T18:59:59Z

cypress/e2e/test.js

+  });
+
+  it("navigating back to home", () => {
+    cy.visit("/");


Same as above, just the other way around.

package.json

Co-Authored-By: andriawan <andriawan2014@gmail.com>

codecov · 2019-04-22T17:26:53Z

Codecov Report

Merging #18 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master    #18   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines          19     19           
  Branches        3      3           
=====================================
  Hits           19     19

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f9f010...39a9b07. Read the comment docs.

codeclimate · 2019-04-22T18:21:39Z

Code Climate has analyzed commit 39a9b07 and detected 0 issues on this pull request.

View more on Code Climate.

zainfathoni

I have reviewed & added some improvements.
Feel free to ask me about my changes if you don't understand them.
Thanks a lot for contributing! 😁

andriawan · 2019-04-22T18:38:13Z

I have reviewed & added some improvements.
Feel free to ask me about my changes if you don't understand them.
Thanks a lot for contributing! 😁

really nice to work with experienced developer/engineer...hope i can contribute more and learn more @zainfathoni

zainfathoni · 2019-04-23T08:29:03Z

No problem.
I know the task in this PR is a lot to take.
Even it requires me to jump in because it contains a few integrated concepts I learnt from this course.

But once you master it, I guarantee that you'll like it so much. 😆
So, please try reviewing the codes thoroughly and don't hesitate to ping me up if there's anything that you don't understand.

I would be more than happy to guide you. 😉

andriawan changed the title ~~early integration of e2e with cypress~~ early integration of e2e test with cypress Apr 20, 2019

zainfathoni requested review from zainfathoni and r17x April 20, 2019 15:48

zainfathoni requested changes Apr 20, 2019

View reviewed changes

package.json Outdated Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

zainfathoni changed the title ~~early integration of e2e test with cypress~~ Early integration of e2e test using Cypress Apr 20, 2019

zainfathoni assigned zainfathoni and andriawan Apr 20, 2019

zainfathoni added the enhancement New feature or request label Apr 20, 2019

zainfathoni added this to In progress in Infrastructure via automation Apr 20, 2019

zainfathoni added this to the MVP Launching milestone Apr 20, 2019

r17x mentioned this pull request Apr 20, 2019

Initial Discussion #1

Open

43 tasks

zainfathoni requested changes Apr 20, 2019

View reviewed changes

Infrastructure automation moved this from In progress to Review in progress Apr 20, 2019

andriawan added 8 commits April 21, 2019 11:03

early integration of e2e with cypress

7a95882

improvement : locking version to avoid unintended upgrades

7dedf83

improvement: deleting default example on folder cypress

a64bcde

implementing custom e2e test & configure e2e test

1279e83

improvement : revise test functionality

e0031d7

improvement : add functionality in existing test

efea384

exclude folder cypress, avoid error in jest console run

7d03902

add new dependecies for testing, modify validate run script

176ebd0

zainfathoni reviewed Apr 21, 2019

View reviewed changes

package.json Outdated Show resolved Hide resolved

add eslint plugin cypress & lock cross-env version

d3443ea

Infrastructure automation moved this from Review in progress to Reviewer approved Apr 22, 2019

zainfathoni reviewed Apr 22, 2019

View reviewed changes

package.json Outdated Show resolved Hide resolved

Update package.json

e9f019f

Co-Authored-By: andriawan <andriawan2014@gmail.com>

andriawan dismissed stale reviews from zainfathoni via e9f019f April 22, 2019 16:20

Infrastructure automation moved this from Reviewer approved to Review in progress Apr 22, 2019

Fix 'test:e2e:run' script by serving in port 8000

3db9b65

zainfathoni added 8 commits April 23, 2019 01:35

Refactor cypress tests

02f0aa8

Use cypress-testing-library for selections & assertions

53f2ce9

Use 'is-ci' command to determine environment

6f9bbab

Rename e2e tests

12220c4

Update scripts & related documentation

9a08b36

Merge branch 'master' into feature/integration-e2e-cypress

323fa15

Remove unnecessary lines in gatsby-node.js

a5a7ab7

Add an assertion in page 2

39a9b07

devpendent deleted a comment from codeclimate bot Apr 22, 2019

zainfathoni self-requested a review April 22, 2019 18:26

zainfathoni approved these changes Apr 22, 2019

View reviewed changes

Infrastructure automation moved this from Review in progress to Reviewer approved Apr 22, 2019

zainfathoni merged commit ded5243 into devpendent:master Apr 22, 2019

Infrastructure automation moved this from Reviewer approved to Done Apr 22, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Early integration of e2e test using Cypress #18

Early integration of e2e test using Cypress #18

andriawan commented Apr 20, 2019 •

edited

zainfathoni left a comment •

edited by andriawan

andriawan commented Apr 20, 2019

andriawan commented Apr 20, 2019

zainfathoni commented Apr 20, 2019

andriawan commented Apr 20, 2019

zainfathoni commented Apr 20, 2019

andriawan commented Apr 20, 2019

zainfathoni Apr 20, 2019

zainfathoni Apr 20, 2019

codecov bot commented Apr 22, 2019 •

edited

codeclimate bot commented Apr 22, 2019

zainfathoni left a comment

andriawan commented Apr 22, 2019

zainfathoni commented Apr 23, 2019 •

edited

Early integration of e2e test using Cypress #18

Early integration of e2e test using Cypress #18

Conversation

andriawan commented Apr 20, 2019 • edited

zainfathoni left a comment • edited by andriawan

Choose a reason for hiding this comment

andriawan commented Apr 20, 2019

andriawan commented Apr 20, 2019

zainfathoni commented Apr 20, 2019

andriawan commented Apr 20, 2019

zainfathoni commented Apr 20, 2019

andriawan commented Apr 20, 2019

zainfathoni Apr 20, 2019

Choose a reason for hiding this comment

zainfathoni Apr 20, 2019

Choose a reason for hiding this comment

codecov bot commented Apr 22, 2019 • edited

Codecov Report

codeclimate bot commented Apr 22, 2019

zainfathoni left a comment

Choose a reason for hiding this comment

andriawan commented Apr 22, 2019

zainfathoni commented Apr 23, 2019 • edited

andriawan commented Apr 20, 2019 •

edited

zainfathoni left a comment •

edited by andriawan

codecov bot commented Apr 22, 2019 •

edited

zainfathoni commented Apr 23, 2019 •

edited