Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Styling Setup #3

Merged
merged 6 commits into from
Apr 19, 2019
Merged

Styling Setup #3

merged 6 commits into from
Apr 19, 2019

Conversation

r17x
Copy link
Contributor

@r17x r17x commented Apr 18, 2019

part of this #1

@r17x r17x requested a review from zainfathoni April 18, 2019 18:35
@r17x r17x self-assigned this Apr 18, 2019
@r17x r17x added the enhancement New feature or request label Apr 18, 2019
@r17x r17x added this to In progress in Infrastructure via automation Apr 18, 2019
@r17x r17x added this to the MVP Launching milestone Apr 18, 2019
@r17x r17x changed the title Styling Development Setup Styling Setup Apr 18, 2019
zainfathoni
zainfathoni requested changes Apr 18, 2019
View reviewed changes
Copy link
Contributor

@zainfathoni zainfathoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ri7nz The latest merge from my #2 PR causes a conflict with this PR.
Please resolve the conflict, thanks!

@r17x r17x requested a review from zainfathoni April 18, 2019 22:56
zainfathoni
zainfathoni approved these changes Apr 18, 2019
View reviewed changes
Copy link
Contributor

@zainfathoni zainfathoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 LGTM!

@zainfathoni zainfathoni self-requested a review April 18, 2019 23:35
zainfathoni
zainfathoni requested changes Apr 18, 2019
View reviewed changes
Copy link
Contributor

@zainfathoni zainfathoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure that react-bulma-components actually works as expected.

gatsby-node.js Show resolved Hide resolved
@r17x r17x requested a review from zainfathoni April 19, 2019 01:49
zainfathoni
zainfathoni approved these changes Apr 19, 2019
View reviewed changes
Copy link
Contributor

@zainfathoni zainfathoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it.

gatsby-node.js Show resolved Hide resolved
@zainfathoni zainfathoni merged commit 272c71b into devpendent:master Apr 19, 2019
Infrastructure automation moved this from In progress to Done Apr 19, 2019
@zainfathoni zainfathoni mentioned this pull request Apr 19, 2019
Merged
This was referenced Apr 20, 2019
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zainfathoni zainfathoni zainfathoni approved these changes

Assignees

@r17x r17x

Labels
enhancement New feature or request
Projects
Infrastructure
  
Done
Milestone
MVP Launching
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@r17x @zainfathoni