Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packaging 22.0 breaks devpi-server for many packages #939

Closed
fyhertz opened this issue Dec 12, 2022 · 5 comments
Closed

Packaging 22.0 breaks devpi-server for many packages #939

fyhertz opened this issue Dec 12, 2022 · 5 comments

Comments

@fyhertz
Copy link

fyhertz commented Dec 12, 2022

Hello,

To reproduce the issue, start a fresh instance of devpi-server and access http://localhost:3143/root/pypi/pytz. packaging 22.0 raises an exception when devpi tries to parse old versions of pytz such as 2004d.

I've made a PR to force packaging <= 21.3 here: #938

Regards,
Simon

@fschulze
Copy link
Contributor

I created a fix without pinning. See fschulze@2aba62c

When there is a parse error, a new legacy version is created which is always sorting smaller than a regular version and uses "natural" sorting with other legacy versions. The order might be different than with packaging. I think I should warn about that in the changelog, but by now every tool warns about legacy version strings, so people shouldn't be using them anymore for current releases. It may affect devpi-client commands like remove with any specifier other than ==.

Could you try with this release?
https://m.devpi.net/fschulze/dev/devpi-common/3.7.1.dev0
https://m.devpi.net/fschulze/dev/+f/6ac/e7aaa2d1196f1/devpi_common-3.7.1.dev0-py2.py3-none-any.whl

@fschulze
Copy link
Contributor

I think I will do a 3.7.1 with the pinning fix and a 4.0.0 with my fix with the next major devpi-server and client releases, as all devpi packages have a devpi-common<4 pin. This should prevent any surprises.

@fschulze
Copy link
Contributor

Fixed with released devpi-common 3.7.1.

@tobyX
Copy link

tobyX commented Mar 16, 2023

Hello, this change also breaks things. You cant install devpi-client together with later versions of tox, black, etc.
Is this really needed for the client also?
I currently solve this by downgrading devpi-common to 3.7.0, before you introduced this change.

@nlewo
Copy link

nlewo commented May 13, 2023

@fschulze Would it be possible to publish a new release with the support of packaging in version 22?

In nixpkgs, we are currently no longer able to build devpi-common because the dependencies of devpi-common already switched to packaging-22.0: NixOS/nixpkgs#231346.

srhb pushed a commit to NixOS/nixpkgs that referenced this issue Jun 29, 2023
It fails to build because it depends on packaging <22 while we use
packaging >22.

See the following issues for details:
- #231346
- devpi/devpi#939
tomodachi94 pushed a commit to tomodachi94/nixpkgs that referenced this issue Jun 29, 2023
It fails to build because it depends on packaging <22 while we use
packaging >22.

See the following issues for details:
- NixOS#231346
- devpi/devpi#939
markmcclain pushed a commit to markmcclain/devpi that referenced this issue Jan 8, 2024
markmcclain pushed a commit to aristanetworks/devpi that referenced this issue Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants