Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automate Render After Event Handler #50

Merged
merged 6 commits into from
Jun 9, 2017
Merged

Automate Render After Event Handler #50

merged 6 commits into from
Jun 9, 2017

Conversation

snuggs
Copy link
Member

@snuggs snuggs commented Jun 8, 2017

@snuggs
Copy link
Member Author

snuggs commented Jun 8, 2017 •
edited
Loading

@janz93 @Robertchristopher @mrbernnz we must set the Event.cancelable flag to true before sending event to handler. Otherwise event.preventDefault () does not convert Event.defaultPrevented from false to true.
Spent an hour pulling my hair out on this one.

https://dom.spec.whatwg.org/#dom-event-cancelable

capture d ecran 2017-06-08 a 17 38 20
capture d ecran 2017-06-08 a 17 39 55

@snuggs snuggs force-pushed the issue/46-automate-render-after-event-handler branch from 6592e44 to f595e37 Compare June 8, 2017 22:37
@snuggs snuggs mentioned this pull request Jun 8, 2017
Closed
@snuggs snuggs merged commit 788771a into master Jun 9, 2017
@snuggs snuggs deleted the issue/46-automate-render-after-event-handler branch June 9, 2017 03:17
@snuggs snuggs mentioned this pull request Jun 9, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@snuggs snuggs

@janz93 janz93

@icyc9 icyc9

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@snuggs @tmornini @janz93 @icyc9