Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typings with esm #165

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Conversation

stuikomma
Copy link

Hi, thanks for the lib! I am currently using it in my third project and got some type errors. This error appears when "moduleResolution" is set to "bundler" in tsconfig.json.

TS7016: Could not find a declaration file for module 'react-use-wizard'.
'/path/to/my/project/node_modules/react-use-wizard/dist/react-use-wizard.esm.js' implicitly has an 'any' type.

There are types at '/path/to/my/project/node_modules/react-use-wizard/dist/index.d.ts', but this result could not be resolved when respecting package.json "exports". 
The 'react-use-wizard' library may need to update its package.json or typings.

In my local test, this change fixed it.

Copy link
Owner

@devrnt devrnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, I really appreciate it

package.json Outdated Show resolved Hide resolved
@stuikomma
Copy link
Author

@devrnt Would you mind overriding the failing job? Or fixing it? I am not familiar with you CI setup. Otherwise, I'll just wait for #167 which should also fix it.

@devrnt
Copy link
Owner

devrnt commented Jul 25, 2023

Can you sync your branch? Pipeline issue should be resolved

@devrnt devrnt merged commit e6fc1e7 into devrnt:main Jul 26, 2023
3 checks passed
@devrnt
Copy link
Owner

devrnt commented Jul 26, 2023

v.2.2.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants