Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(notification-hub): should open notification link in new tab #275

Merged
merged 2 commits into from May 14, 2022

Conversation

devrsi0n
Copy link
Owner

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Checklist

  • Unit tests and integration tests passed
  • No reduction in test coverage
  • Documentation is up to date (if appropriate)
  • Related issues linked using fixes #number

@vercel
Copy link

vercel bot commented May 14, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
chirpy ✅ Ready (Inspect) Visit Preview May 14, 2022 at 2:02PM (UTC)

@github-actions
Copy link
Contributor

github-actions bot commented May 14, 2022

Coverage report for ./apps/main

Branches coverage not met for global: expected >=26%, but got 25.441967717140663%

St.
Category Percentage Covered / Total
🔴 Statements 37.09% 1893/5104
🔴 Branches 25.44% 662/2602
🔴 Functions 31.04% 348/1121
🔴 Lines 36.51% 1724/4722
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / use-is-widget.ts
100% 100% 100% 100%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / notification-item.tsx
100%
84.62% (-6.29% 🔻)
100% 100%

Test suite run success

53 tests passing in 35 suites.

Report generated by 🧪jest coverage report action from 0990040

@relativeci
Copy link

relativeci bot commented May 14, 2022

Job #217: Bundle Size — 2.4MB (0%).

a5f2ab5 vs a5f2ab5

Changed metrics (1/10)
Metric Current Baseline
Cache Invalidation 0% 2.66%
Changed assets by type (0/7)

No changes


View Job #217 report on app.relative-ci.com

@cypress
Copy link

cypress bot commented May 14, 2022



Test summary

7 0 0 0


Run details

Project chirpy
Status Passed
Commit 0990040
Started May 14, 2022 2:03 PM
Ended May 14, 2022 2:04 PM
Duration 01:25 💡
OS Linux Ubuntu - 20.04
Browser Electron 94

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@devrsi0n devrsi0n merged commit a5f2ab5 into main May 14, 2022
@devrsi0n devrsi0n deleted the fix/notification-link-2 branch May 14, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant