fix: ignore karma tokens inside code blocks #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgaticaq
approved these changes
May 6, 2019
|
No funciona si hay un karma fuera de los code blocks igual al que está adentro |
gaulatti
reviewed
May 22, 2020
| const findTextInsideCodeBlocks = message => { | ||
| const regex = /`(.*?)`/g | ||
| let matches = [] | ||
| let match |
There was a problem hiding this comment.
cual es el beneficio de este let?
gaulatti
reviewed
May 22, 2020
Comment on lines
+166
to
+168
| while ((match = regex.exec(message)) !== null) { | ||
| matches.push(match[0]) | ||
| } |
There was a problem hiding this comment.
no sería mejor usar un mecanismo tipo optional para esto?
Encuentro que darle con el while es como darse muchas vueltas
gmq
force-pushed
the
master
branch
3 times, most recently
from
fde96ef
to
d12d3d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pequeño cambio para evitar asignar karma cuando se agrega código.
Cualquier cosa que este dentro ` (backtick) va a ser escapada de la asignación de karma.
TLDR; No más
no encuentro al usuario c++