Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

goquic/example/client.go does not seem to work with any real-world QUIC apps #21

Closed
gripedthumbtacks opened this issue Mar 7, 2016 · 2 comments
Closed

goquic/example/client.go does not seem to work with any real-world QUIC apps #21

gripedthumbtacks opened this issue Mar 7, 2016 · 2 comments

Comments

@gripedthumbtacks
Copy link

I tested this:

github.com/devsisters/goquic/example/client.go

But it cannot connect to any real-world services, like https://www.google.com:443/. I modified it as such to no avail. Here is the error output:

$ go run client.go 2>&1 | egrep -i 'warn|err|fail'
  RREJ: SERVER_CONFIG_INCHOATE_HELLO_FAILURE
[0307/034553:VERBOSE1:quic_connection.cc(2030)] Client: Force closing 9814791807430471583 with error QUIC_PEER_GOING_AWAY (16) Client disconnectiong
[0307/034553:VERBOSE1:quic_packet_creator.cc(740)] Adding frame: type { CONNECTION_CLOSE_FRAME } error_code { 16 } error_details { Client disconnectiong }
<html><title>Error 400 (Bad Request)!!1</title></html>

Has this been tested on any real-world services other than the demo server? Or is QUIC too much in flux still? If the latter, totally understandable. If not, wanted to point it out so others have a documented place to seek resolution. I also noticed this comment in the base client.go foundation at github.com/devsisters/goquic/client.go:

if q.keepConnection {
                resp.Body = ioutil.NopCloser(st)
        } else {
                // XXX(hodduc): "conn" should be closed after the user reads all response body, so
                // it's hard to determine when to close "conn". So we read all response body prematurely.
                // If response is very big, this could be problematic. (Consider using runtime.finalizer())
                body, err := ioutil.ReadAll(st)
                if err != nil {
                        return nil, err
                }
                resp.Body = ioutil.NopCloser(bytes.NewBuffer(body))

                conn.Close()
        }

Can you just use defer on the close? If not, something like this below instead via io.Copy?

body, err := ioutil.ReadAll(resp.Body)
io.Copy(ioutil.Discard, resp.Body)
resp.Body.Close()
hodduc added a commit that referenced this issue Mar 11, 2016
@hodduc
client: Replace :host pseudo-header with :authority (#21)
fac12bb
@hodduc
Copy link
Member

hodduc commented Mar 11, 2016

👍 It worked at that time, but seems to be broken sometime....
The problem is invalid request header. I found that :host header is not valid anymore, and :authority header is necessary according to HTTP2 standard. After fac12bb, https://www.google.com:443/ works well with example client.

@serialx
Copy link
Member

serialx commented Mar 15, 2016

Can you try it out and close the issue when it's verified that it's fixed?

@serialx serialx closed this as completed Apr 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gripedthumbtacks @serialx @hodduc