Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asm pkg dep conflict with common android build #44

Closed
lklots opened this issue Aug 3, 2015 · 2 comments
Closed

asm pkg dep conflict with common android build #44

lklots opened this issue Aug 3, 2015 · 2 comments

Comments

@lklots
Copy link

lklots commented Aug 3, 2015

When running jfairy on android with roboelectric 3.0+, there is a package dependency mismatch against the asm library. jfairy runs on asm:asm:3.1 which is nearly a decade old while roboelectric run against asm 5.+. The pkg dep output for jfairy is below.

Injection is good and all but by including it in this library it increases the surface area for conflicts like above. When making the trade-off in terms of library maintainability vs. compatibility I would side on the compatibility especially as in the case of a library like this that really doesn't require injection or joda time etc.

+--- io.codearte.jfairy:jfairy:0.4.1
| +--- com.google.guava:guava:[15.0,) -> 19.0-rc1
| +--- com.google.inject:guice:3.0
| | +--- javax.inject:javax.inject:1
| | +--- aopalliance:aopalliance:1.0
| | --- org.sonatype.sisu.inject:cglib:2.2.1-v20090111
| | --- asm:asm:3.1 <----------------------------------------- conflict
| +--- org.yaml:snakeyaml:[1.9,2.0) -> 1.15
| +--- org.iban4j:iban4j:2.1.1
| +--- com.google.inject.extensions:guice-assistedinject:3.0
| | --- com.google.inject:guice:3.0 (*)
| +--- joda-time:joda-time:2.3
| +--- org.reflections:reflections:0.9.9
| | +--- com.google.guava:guava:15.0 -> 19.0-rc1
| | +--- org.javassist:javassist:3.18.2-GA -> 3.19.0-GA
| | --- com.google.code.findbugs:annotations:2.0.1
| +--- org.apache.commons:commons-lang3:3.3.2
| --- org.slf4j:slf4j-api:1.7.7

@jkubrynski
Copy link
Member

@lklots have you tried exluding asm from guice dependency?

jkubrynski added a commit that referenced this issue Aug 5, 2015
@OlgaMaciaszek
Copy link
Contributor

@lklots We have raised Guice version to 4.0 in JFairy 0.5.0. This should help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants