Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Xamarin.iOS] Error on method call ClearCookiesAsync() #4

Closed
stoff99 opened this issue Jan 31, 2020 · 7 comments
Closed

[Xamarin.iOS] Error on method call ClearCookiesAsync() #4

stoff99 opened this issue Jan 31, 2020 · 7 comments

Comments

@stoff99
Copy link

stoff99 commented Jan 31, 2020

Hello @candidodmv ,

Sorry for spamming your Git repo but we found a bug when we call the method ClearCookiesAsync() on iOS.
Screenshot_31_01_20__13_37

Xamarin Version: 4.3.0.991211
iOS: 13.1.3

Greetings
Stefan

@stoff99
Copy link
Author

stoff99 commented Jan 31, 2020

We currently found out that the same appears when you call the method GetAllCookiesAsync()

Screenshot_31_01_20__14_01

@candidodmv
Copy link
Contributor

candidodmv commented Feb 11, 2020

Hello @stoff99 , I'm looking in the source code, and i suppouse that what is causing this exceptions in both methods above, is due the tried of parse the Element.Source URL:

var url = new Uri(Element.Source);

I'm considering instead of use Uri.Parse, use Uri.TryCreate, but I don't guarantee if is the best choice, could you help me to decide this?

@stoff99
Copy link
Author

stoff99 commented Feb 11, 2020

Hi @candidodmv ,
yes i think that makes sense.
After the parse check if the url is null.

candidodmv pushed a commit that referenced this issue Feb 11, 2020
@candidodmv
Copy link
Contributor

@stoff99 I've pushed the new alpha release with this and #2 issue right now on a version 1.0.0.2-alpha

@stoff99
Copy link
Author

stoff99 commented Feb 18, 2020

Hello @candidodmv ,

this is fixed now. I don't get any exception with the 1.0.0.2 anymore.
Thx a lot

@candidodmv
Copy link
Contributor

That's great @stoff99

@TechnikKTK
Copy link

Hello. I am using your solution, but I have an error. When calling the InjectJavaScriptAsync method, namely the result of calling callBack. There is an error describing the csharp function in the readme() on JS. because your code requires Base64 encoding and does not skip simple commands like eventObj.Sender.injectjavascript("csharp('Testing');"); because there is also deserialization going on. I corrected my hybrid, but somewhere in HandleScriptReceived there is an Exception null reference. I don't understand where.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants