fix regression with static methods

devsnek · Mar 1, 2018 · 8dc7321 · 8dc7321
1 parent 5948edd
commit 8dc7321
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "snekfetch",
-  "version": "4.0.0-rc.0",
+  "version": "4.0.0-beta.0",
   "main": "src/index",
   "module": "src/index.mjs",
   "unpkg": "browser.js",

diff --git a/src/index.js b/src/index.js
@@ -236,7 +236,7 @@ class Snekfetch extends transport.Parent {
 Snekfetch.METHODS = transport.METHODS.filter((m) => m !== 'M-SEARCH');
 for (const method of Snekfetch.METHODS) {
   Snekfetch[method.toLowerCase()] = function runMethod(url, opts) {
-    const Constructor = this.prototype instanceof Snekfetch ? this : Snekfetch;
+    const Constructor = this && this.prototype instanceof Snekfetch ? this : Snekfetch;
     return new Constructor(method, url, opts);
   };
 }

diff --git a/test/main.js b/test/main.js
@@ -24,8 +24,14 @@ function makeTestObj({ unicode = true, numbers = false } = {}) {
 }
 
 test('should return a promise', () => {
-  expect(Snekfetch.get(`${TestRoot}/get`).end())
-    .toBeInstanceOf(Promise);
+  for (const C of [
+    Snekfetch.get(`${TestRoot}/get`).end(),
+    Snekfetch.get.call(null, `${TestRoot}/get`).end(),
+    Snekfetch.get.call({}, `${TestRoot}/get`).end(),
+  ]) {
+    expect(C)
+      .toBeInstanceOf(Promise);
+  }
 });
 
 test('should reject with error on network failure', () => {