Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic on devspace remove deployment --all #645

Closed
FabianKramm opened this issue Aug 21, 2019 · 2 comments
Closed

Panic on devspace remove deployment --all #645

FabianKramm opened this issue Aug 21, 2019 · 2 comments
Assignees
Labels
area/config Issues related to the config kind/bug Something isn't working

Comments

@FabianKramm
Copy link
Collaborator

FabianKramm commented Aug 21, 2019

A panic is thrown on devspace remove deployment --all

$ devspace remove deployment --all
[info]   Loaded config devspace.yaml
? Do you want to delete all deployment resources deployed?
 no
panic: runtime error: index out of range

goroutine 1 [running]:
github.com/devspace-cloud/devspace/cmd/remove.(*deploymentCmd).RunRemoveDeployment(0xc0004530a9, 0xc000dbd400, 0xc0010a1e80, 0x0, 0x1)
        /Users/fabiankramm/Programmieren/go-workspace/src/github.com/devspace-cloud/devspace/cmd/remove/deployment.go:105 +0x912
github.com/spf13/cobra.(*Command).execute(0xc000dbd400, 0xc0010a1e60, 0x1, 0x1, 0xc000dbd400, 0xc0010a1e60)
        /Users/fabiankramm/Programmieren/go-workspace/src/github.com/devspace-cloud/devspace/vendor/github.com/spf13/cobra/command.go:766 +0x2ae
github.com/spf13/cobra.(*Command).ExecuteC(0x76b24c0, 0x5c46840, 0xc0003e2a00, 0xc000519640)
        /Users/fabiankramm/Programmieren/go-workspace/src/github.com/devspace-cloud/devspace/vendor/github.com/spf13/cobra/command.go:852 +0x2ec
github.com/spf13/cobra.(*Command).Execute(...)
        /Users/fabiankramm/Programmieren/go-workspace/src/github.com/devspace-cloud/devspace/vendor/github.com/spf13/cobra/command.go:800
github.com/devspace-cloud/devspace/cmd.Execute()
        /Users/fabiankramm/Programmieren/go-workspace/src/github.com/devspace-cloud/devspace/cmd/root.go:55 +0xe8
@FabianKramm FabianKramm added kind/bug Something isn't working area/config Issues related to the config labels Aug 21, 2019
@FlorianKutz
Copy link
Contributor

FlorianKutz commented Aug 22, 2019

The same goes for "devspace remove image --all". Here it is even worse because the Done-message doesn't tell you whether the deleted image was there before the deletion.

EDIT: Also other remove commands aren't responsive about whether there was an item that was deleted. These are context, port, selector, space(Only with all-flag), and sync.

@FabianKramm
Copy link
Collaborator Author

Fixed in v3.5.18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/config Issues related to the config kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants