Added Validation Regex and Message to the user provided registry username #2620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandradragodan
requested review from
FabianKramm and
LukasGentele
as code owners
✅ Deploy Preview for devspace-docs canceled.
|
89luca89
approved these changes
Apr 6, 2023
|
LGTM |
…name Signed-off-by: Alexandra Dragodan <alexandra@loft.sh>
Signed-off-by: Alexandra Dragodan <alexandra@loft.sh>
alexandradragodan
force-pushed
the
alexandra/devspace-init-lowercase-registry-username
branch
from
b96947b
to
066263b
Compare
| @@ -172,8 +172,10 @@ func (m *manager) AddImage(imageName, image, projectNamespace, dockerfile string | |||
| registryHostname = generator.GithubContainerRegistry | |||
| } else { | |||
| registryHostname, err = m.log.Question(&survey.QuestionOptions{ | |||
| Question: "Please provide the registry hostname without the image path (e.g. gcr.io, ghcr.io, ecr.io)", | |||
| DefaultValue: "gcr.io", | |||
| Question: "Please provide the registry hostname without the image path (e.g. gcr.io, ghcr.io, ecr.io)", | |||
There was a problem hiding this comment.
remove hostname check
FabianKramm
deleted the
alexandra/devspace-init-lowercase-registry-username
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Validation Regex and Message to the user provided registry username
What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves #
Fixes ENG-701
Please provide a short message that should be published in the DevSpace release notes
Fixed an issue where DevSpace connected registry username was not checked for UpperCase letters.
What else do we need to know?