Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace github.com/ghodss/yaml with sigs.k8s.io/yaml #2663

Merged
merged 1 commit into from Aug 17, 2023
Merged

chore: replace github.com/ghodss/yaml with sigs.k8s.io/yaml #2663

merged 1 commit into from Aug 17, 2023

Conversation

Juneezee
Copy link
Contributor

@Juneezee Juneezee commented Jul 1, 2023

/kind enhancement

What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible)
resolves #

The github.com/ghodss/yaml package is no longer actively maintained. There are numerous inquiries about the project's status on its issue tracker: https://github.com/ghodss/yaml/issues. sigs.k8s.io/yaml is a permanent fork of github.com/ghodss/yaml, which is actively maintained by Kubernetes SIG and widely used in K8s projects.

Please provide a short message that should be published in the DevSpace release notes
Replace unmaintained github.com/ghodss/yaml dependency with sigs.k8s.io/yaml.

What else do we need to know?

@netlify
Copy link

netlify bot commented Jul 1, 2023

Deploy Preview for devspace-docs canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 5947e58
🔍 Latest deploy log https://app.netlify.com/sites/devspace-docs/deploys/64d5c4f8cdbcb00008f91352

@Juneezee
Copy link
Contributor Author

Hello @FabianKramm @LukasGentele . I apologize for the explicit mention, but I wanted to follow up on this pull request I created some time ago.

I would be grateful if you could take some time to review the changes and provide me with your feedback. If there are any specific concerns or questions you have about the changes, I am more than willing to help address them.

Thank you for your time and consideration. I truly appreciate it. ❤️

At the time of making this commit, the package `github.com/ghodss/yaml`
is no longer actively maintained.

`sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively
maintained by Kubernetes SIG.

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
Copy link
Collaborator

@lizardruss lizardruss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the PR!

LGTM

@lizardruss lizardruss merged commit a32aff7 into devspace-sh:main Aug 17, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants