Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add localRegistry to imported sections #2666

Merged
merged 1 commit into from Jul 7, 2023

Conversation

lizardruss
Copy link
Collaborator

@lizardruss lizardruss commented Jul 5, 2023

What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix

What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible)
resolves #2665
Fixes ENG-1686

Please provide a short message that should be published in the DevSpace release notes
Fixed an issue where DevSpace did not import localRegistry configuration

What else do we need to know?
Added a section to the docs to describe import sections that are importable.

@netlify
Copy link

netlify bot commented Jul 5, 2023

Deploy Preview for devspace-docs canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 72d01e0
🔍 Latest deploy log https://app.netlify.com/sites/devspace-docs/deploys/64a5b1057d1be60008d4825e

Fixes devspace-sh#2665
Fixes ENG-1686

Signed-off-by: Russell Centanni <russell.centanni@gmail.com>
@lizardruss lizardruss marked this pull request as ready for review July 5, 2023 18:08
@lizardruss lizardruss requested a review from 89luca89 July 5, 2023 18:08
Copy link
Collaborator

@FabianKramm FabianKramm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lizardruss thanks a lot for the PR! LGTM!

@FabianKramm FabianKramm merged commit 49d2fec into devspace-sh:main Jul 7, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

localRegistry property is not "importable"
2 participants