fix: run_watch glob pattern handling #2728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for devspace-docs canceled.Built without sensitive environment variables
|
FabianKramm
requested changes
Oct 5, 2023
There was a problem hiding this comment.
@89luca89 we nee testing for this before we want to merge it.
89luca89
force-pushed
the
fix/run_watch_globs
branch
from
963459e
to
409e143
Compare
FabianKramm
requested changes
Oct 9, 2023
pkg/devspace/pipeline/engine/basichandler/commands/run_watch.go
Outdated
Show resolved
Hide resolved
89luca89
force-pushed
the
fix/run_watch_globs
branch
from
409e143
to
0b1d827
Compare
Signed-off-by: Luca Di Maio <luca.dimaio1@gmail.com>
Signed-off-by: Luca Di Maio <luca.dimaio1@gmail.com>
Signed-off-by: Luca Di Maio <luca.dimaio1@gmail.com>
89luca89
force-pushed
the
fix/run_watch_globs
branch
from
0b1d827
to
2d4121d
Compare
FabianKramm
approved these changes
Oct 9, 2023
Testing included 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind bugfix
Fix #2656
Resolves ENG-1530
This will fix the globbing being resolved before the flag handling in the
run_watchpipeline